wxListCtrl::SetItemData Memory Leak

[radez]

Has anyone had any experience with the ListCtrl SetItemData?

I am populating a list from a database and for each item I'm am calling this function:

LstCtrl->SetItemData(ct, atol(res));

(int) ct is my count keeping track of which index I'm on in the list and res is a string returned from my database.

I'm assuming this Data container is for what ever you want to put in it and not anything in particular right?

when I comment this one line out I don't get the memory leak per list entry.

Is there a place to findout if this is bug? I don't know much about bug reporting. Let me know if anyone would like to see more code.

Thanks

Radez

[ConnorMacLeod]

I have the same problem: memory leak with ListCtrl.

Even the wxWidgets sample of ListCtrl has a memory leak so i assume that's a wx bug.

[rex666]

The problem seems to be in the wxListCtrl::MSWOnNotify method

It sets the count to zero before the event is sent, and then tries to clean up the user data after, but because the count was already set to zero, wxListCtrl::FreeAllInternalData doesn't free anything.

I moved the m_count = 0 line to be after the call to FreeAllInternalData() that happens in the post-processing of the MSWOnNotify call, and it seems to work better.

In wxWidgets 2.5.3, the change is:
src\msw\listctrl.cpp:
comment out line 1905
add at line 2180:
m_count = 0;

[Avi]

Create a proper patch and post it on the SF.net Patches tracker

[rex666]

This is a stupid question, but how do I create a patch?

Thanks
-robin

[Avi]

I can assure you we all asked that question... You can find the information here: http://www.wxwidgets.org/technote/patches.htm

[Ryan Norton]

I can assure you we all asked that question... You can find the information here: http://www.wxwidgets.org/technote/patches.htm

Heck, I don't know why I didn't put this in the FAQ sooner

[rex666]

I see it has already been fixed in 2.6.1

Thanks
-robin