wxDataViewListCtrl bug about scrollbar

[Ronald]

I can't upload image on https://trac.wxwidgets.org, so I posted here for a image link. trac: https://trac.wxwidgets.org/ticket/18343

Capture.PNG

MainFrame.h

Code: Select all

#pragma once

class MainFrame : public wxFrame
{
    DECLARE_EVENT_TABLE()
public:
    MainFrame(wxWindow* parent, wxWindowID id = wxID_ANY, const wxString& title = wxEmptyString, const wxPoint& pos = wxDefaultPosition, const wxSize& size = wxSize(709, 463), long style = wxDEFAULT_FRAME_STYLE);
    ~MainFrame();
private:
    void InitDataViewListCtrl(wxDataViewListCtrl * dvlc);
private:
    wxDataViewListCtrl * dvlc;
};

MainFrame.cpp

Code: Select all

#include "stdafx.h"
#include "MainFrame.h"

BEGIN_EVENT_TABLE(MainFrame, wxFrame)
END_EVENT_TABLE()

MainFrame::MainFrame(wxWindow* parent, wxWindowID id, const wxString& title, const wxPoint& pos, const wxSize& size, long style) : wxFrame(parent, id, title, pos, size, style)
{
    wxBoxSizer * sizer = new wxBoxSizer(wxVERTICAL);
    dvlc = new wxDataViewListCtrl(this, wxID_ANY, wxDefaultPosition, wxSize(400, 100));
    InitDataViewListCtrl(dvlc);
    sizer->Add(dvlc, 1);
    SetSizer(sizer);
}

MainFrame::~MainFrame()
{
}

void MainFrame::InitDataViewListCtrl(wxDataViewListCtrl * dvlc)
{
    wxDataViewColumn * col = nullptr;
    dvlc->AppendTextColumn(L"aaa");
    dvlc->AppendTextColumn(L"bbb");
    dvlc->AppendTextColumn(L"ccc");
    dvlc->AppendTextColumn(L"ddd");
    dvlc->AppendTextColumn(L"eee");

    wxVector<wxVariant> data;
    data.push_back("aaaaaaaa");
    data.push_back("bbbbbbbb");
    data.push_back("cccccccc");
    data.push_back("dddddddd");
    data.push_back("eeeeeeee");
    dvlc->AppendItem(data);    
}

[PB]

I just skimmed through the post, but where is the bug? According to the screenshot, there is no reason to display scrollbars, all the columns are fully displayed (fit to the control's width), the value of the last one being ellipsized (you can see the right border of the last column)? The horizontal scrollbar logically appears only when necessary, i.e., the sum of columns' widths < the control's width, this is not the case in the screenshot.

You can see that the scrollbar appear when you pass a long width when appending a column:

Code: Select all

#include <wx/wx.h>
#include <wx/dataview.h>

class MyFrame : public wxFrame
{
public:
    MyFrame() : wxFrame(NULL, wxID_ANY, "Test")
    {               
        wxDataViewListCtrl* dvlc = new wxDataViewListCtrl(this, wxID_ANY, wxDefaultPosition, wxSize(400, 100));
        
        dvlc->AppendTextColumn("aaa");
        dvlc->AppendTextColumn("bbb");
        dvlc->AppendTextColumn("ccc");
        dvlc->AppendTextColumn("ddd");
        dvlc->AppendTextColumn("eee", wxDATAVIEW_CELL_INERT, 300);

        wxVector<wxVariant> data;
        
        data.push_back("aaaaaaaa");
        data.push_back("bbbbbbbb");
        data.push_back("cccccccc");
        data.push_back("dddddddd");
        data.push_back("eeeeeeee");
        dvlc->AppendItem(data);
    }
};

class MyApp : public wxApp
{
public:	
	bool OnInit()
	{
        wxInitAllImageHandlers();
        (new MyFrame)->Show();
        return true;
	}
}; wxIMPLEMENT_APP(MyApp);

dvcscroll.png

[doublemax]

You also didn't let the control expand in horizontal direction.

Replace

Code: Select all

sizer->Add(dvlc, 1);

with

Code: Select all

sizer->Add(dvlc, 1, wxEXPAND);

[Ronald]

The horizontal scrollbar logically appears only when necessary, i.e., the sum of columns' widths < the control's width, this is not the case in the screenshot.

When the sum of columns' width is not enough, still no horizontal scrollbar.

original

Capture1.PNG

after resizing manually

Capture2.PNG

[PB]

What wxWidgets version you have, the behaviour regarding the last column width in wxDVC was changed not so long ago, see e.g.
https://github.com/wxWidgets/wxWidgets/ ... af0771f21c
https://github.com/wxWidgets/wxWidgets/ ... 076a11e257

I used the master for my test above.

EDIT
The width of the column is not the same as the width of the strings displayed in the column header or rows. You can see whether the column is fully displayed when you see the line of the right border of its head. If you need a different column width you need to adjust it.

[Ronald]

You also didn't let the control expand in horizontal direction.

Replace

Code: Select all

sizer->Add(dvlc, 1);

with

Code: Select all

sizer->Add(dvlc, 1, wxEXPAND);

It's fine, but there is a bug

Capture3.PNG

[PB]

It's fine, but there is a bug

Once again, wxWidgets version? As I already wrote above, I believe there were quite a few changes regarding the last column resizing
https://github.com/wxWidgets/wxWidgets/ ... pe=Commits

I.e., can you reproduce "the bug" with the GIT master head?

[Ronald]

What wxWidgets version you have

3.1.2

The width of the column is not the same as the width of the strings displayed in the column header or rows. You can see whether the column is fully displayed when you see the line of the right border of its head. If you need a different column width you need to adjust it.

In my last, the first image shows that the total wxDataViewCtrl shows as expected, but when I resize the frame, the horizontal scrollbar doesn't show until the last-1 col (titled "ddd") has not enough space to show.

BTW, I'm trying the master commit of git repository.

[Ronald]

It's fine, but there is a bug

Once again, wxWidgets version? As I already wrote above, I believe there were quite a few changes regarding the last column resizing
https://github.com/wxWidgets/wxWidgets/ ... pe=Commits

I.e., can you reproduce "the bug" with the GIT master head?

This bug doesn't exist in the master commit


However, the bug about scroll bar remains the same.

[doublemax]

...but when I resize the frame, the horizontal scrollbar doesn't show until the last-1 col (titled "ddd") has not enough space to show.

Please add this to the ticket on Trac. Before that it wasn't clear (at least to me) what the bug was.

[Ronald]

...but when I resize the frame, the horizontal scrollbar doesn't show until the last-1 col (titled "ddd") has not enough space to show.

Please add this to the ticket on Trac. Before that it wasn't clear (at least to me) what the bug was.

added