Dialogs and Destroy() Topic is solved

[Peterj]

Could someone correct my misunderstanding:

I have created several modal dialogs which usually include a Cancel button to which I attach an onclick event. Inside the event I usually put:

Code: Select all

Destroy(); 

to close the dialog.

However this appears to cause the dialogs to close not only themselves, but also the window they were activated from. Running debug I have found using Destroy() has caused an access violation and everything is being closed.

So I have got rid of the event, and set the button ID to wxID_CANCEL. Now my dialog closes as it should. (I also note that using wxID_CLOSE does not close the dialog.)

I understand that the best way to reclaim memory is to use Destroy(), so I have put it into the dialog destructor. It doesn't appear to cause any bad consequences, but is it a valid use of Destroy()?

If anyone could shed any light on the problem, or fill in some gaps in my understanding, it would be appreciated.

Peter

[upCASE]

Hi!

I understand that the best way to reclaim memory is to use Destroy(), so I have put it into the dialog destructor. It doesn't appear to cause any bad consequences, but is it a valid use of Destroy()?

If anyone could shed any light on the problem, or fill in some gaps in my understanding, it would be appreciated.

In general this correct for controls created on the heap (using new) instead of on the stack. Normaly you wouldn't create a modal dialog on the heap. You simply do somehting like

Code: Select all

MyDialog dlg(...);
dlg.ShowModal();

and don't call Destroy explicitly. It will be called by th dtor of the dialog as soon as it goes out of scope.
To close a modal dialog, call EndModal() from it and pass the return code.

[Peterj]

Hi upCase,

Thanks for your reply.

I forgot to mention that these are created on the heap. Some of the dialogs get reasonably complicated so I have been under the impression they would be better created there.

In this situation, is it valid to put Destroy() in the dtor?

When the access violation error occurs, debug points to wxEventTableEntry in event.h

Peter

[upCASE]

I forgot to mention that these are created on the heap. Some of the dialogs get reasonably complicated so I have been under the impression they would be better created there.

In this situation, is it valid to put Destroy() in the dtor?

When the access violation error occurs, debug points to wxEventTableEntry in event.h

No matter how complicated the dialogs are, if you can create them on the stack when using ShowModal().
Anyway: Don't call Destroy() from the dialog itself. Call it from the calling method after ShowModal() returned.

[Peterj]

Thanks for the reply. I'll move the Destroy() and check out the difference.

Peter