Page 1 of 1

How to upload code to demonstrate a bug?

Posted: Fri Sep 27, 2019 1:51 am
by Ronald
I filed a bug on https://trac.wxwidgets.org/ with an attachment of a custom VS2019 solution,
they usually asked like: Can the bug be reproduced in the wxWidgets' samples?
So, is it ok to do a PR on github to show the bug? Or a standalone patch?

Thanks

Re: How to upload code to demonstrate a bug?

Posted: Fri Sep 27, 2019 5:04 am
by doublemax
Is it about the wxPropertyGrid bug?
So, is it ok to do a PR on github to show the bug? Or a standalone patch?
One of these is usually preferred.

Re: How to upload code to demonstrate a bug?

Posted: Fri Sep 27, 2019 5:30 am
by PB
Just keep in mind that the code change should be as small as described here
https://trac.wxwidgets.org/wiki/HowToSu ... theProblem

There is usually no reason to provide project files...

Re: How to upload code to demonstrate a bug?

Posted: Fri Sep 27, 2019 10:15 am
by Ronald
doublemax wrote:
Fri Sep 27, 2019 5:04 am
Is it about the wxPropertyGrid bug?
Not only, I have filed 3 bugs.
BTW, 2 bugs are fixed instantly, but the status of the wxPropertyGrid bug has been new for 12 days https://trac.wxwidgets.org/ticket/18502
doublemax wrote:
Fri Sep 27, 2019 5:04 am
So, is it ok to do a PR on github to show the bug? Or a standalone patch?
One of these is usually preferred.
Which one? Any one?

Re: How to upload code to demonstrate a bug?

Posted: Fri Sep 27, 2019 10:20 am
by Ronald
PB wrote:
Fri Sep 27, 2019 5:30 am
Just keep in mind that the code change should be as small as described here
https://trac.wxwidgets.org/wiki/HowToSu ... theProblem
OK. BTW, In China, visit trac & forum of wxWidgets is very slow, so I become lazy to visit more web pages. However the doc is good. Thanks.
PB wrote:
Fri Sep 27, 2019 5:30 am
There is usually no reason to provide project files...
Yes, platform dependent and lib path dependent.

Re: How to upload code to demonstrate a bug?

Posted: Fri Sep 27, 2019 10:27 am
by PB
PB wrote:
Fri Sep 27, 2019 5:30 am
There is usually no reason to provide project files...
Yes, platform dependent and lib path dependent.
[/quote]

Platform dependency has nothing to with the project files. The code needs to run regardless of the IDE, not to mention that some project files are multiplatform. The platform is specified in the ticket. If the issue is with a specific compiler, it just needs to be mentioned. Last but not least, a code reproducing the issue is usually in a single file.

As for lib path dependency, TBH I really cannot imagine this kind of a bug, as paths can be freely modified in users' projects. I am not saying this cannot happen, but I believe it to be quite rare.

Re: How to upload code to demonstrate a bug?

Posted: Fri Sep 27, 2019 10:28 am
by doublemax
Ronald wrote:
Fri Sep 27, 2019 10:15 am
doublemax wrote:
Fri Sep 27, 2019 5:04 am
So, is it ok to do a PR on github to show the bug? Or a standalone patch?
One of these is usually preferred.
Which one? Any one?
Yes. Any one of those.

Re: How to upload code to demonstrate a bug?

Posted: Fri Sep 27, 2019 12:43 pm
by Ronald
PB wrote:
Fri Sep 27, 2019 10:27 am
As for lib path dependency, TBH I really cannot imagine this kind of a bug, as paths can be freely modified in users' projects. I am not saying this cannot happen, but I believe it to be quite rare.
I mean if providing a Visual Studio solution, the lib path for wxWidgets needs to be changed for others to run the solution.
This is not convenient.
A patch on the samples is convenient.

Re: How to upload code to demonstrate a bug?

Posted: Mon Sep 30, 2019 2:38 pm
by ONEEYEMAN
Hi,
Yes, that's why people request a patch to the sample.
On top of that Vadim simply doesn't have time to study the full code, and it is easier to just apply the patch and do some debugging, then read the code, understand it and start the debugging session.

Thank you.