How to upload code to demonstrate a bug? Topic is solved

This forum can be used to talk about general design strategies, new ideas and questions in general related to wxWidgets. If you feel your questions doesn't fit anywhere, put it here.
Post Reply
Ronald
I live to help wx-kind
I live to help wx-kind
Posts: 162
Joined: Mon Mar 05, 2018 4:17 am

How to upload code to demonstrate a bug?

Post by Ronald » Fri Sep 27, 2019 1:51 am

I filed a bug on https://trac.wxwidgets.org/ with an attachment of a custom VS2019 solution,
they usually asked like: Can the bug be reproduced in the wxWidgets' samples?
So, is it ok to do a PR on github to show the bug? Or a standalone patch?

Thanks

User avatar
doublemax
Moderator
Moderator
Posts: 14870
Joined: Fri Apr 21, 2006 8:03 pm
Location: $FCE2

Re: How to upload code to demonstrate a bug?

Post by doublemax » Fri Sep 27, 2019 5:04 am

Is it about the wxPropertyGrid bug?
So, is it ok to do a PR on github to show the bug? Or a standalone patch?
One of these is usually preferred.
Use the source, Luke!

PB
Part Of The Furniture
Part Of The Furniture
Posts: 2421
Joined: Sun Jan 03, 2010 5:45 pm

Re: How to upload code to demonstrate a bug?

Post by PB » Fri Sep 27, 2019 5:30 am

Just keep in mind that the code change should be as small as described here
https://trac.wxwidgets.org/wiki/HowToSu ... theProblem

There is usually no reason to provide project files...

Ronald
I live to help wx-kind
I live to help wx-kind
Posts: 162
Joined: Mon Mar 05, 2018 4:17 am

Re: How to upload code to demonstrate a bug?

Post by Ronald » Fri Sep 27, 2019 10:15 am

doublemax wrote:
Fri Sep 27, 2019 5:04 am
Is it about the wxPropertyGrid bug?
Not only, I have filed 3 bugs.
BTW, 2 bugs are fixed instantly, but the status of the wxPropertyGrid bug has been new for 12 days https://trac.wxwidgets.org/ticket/18502
doublemax wrote:
Fri Sep 27, 2019 5:04 am
So, is it ok to do a PR on github to show the bug? Or a standalone patch?
One of these is usually preferred.
Which one? Any one?

Ronald
I live to help wx-kind
I live to help wx-kind
Posts: 162
Joined: Mon Mar 05, 2018 4:17 am

Re: How to upload code to demonstrate a bug?

Post by Ronald » Fri Sep 27, 2019 10:20 am

PB wrote:
Fri Sep 27, 2019 5:30 am
Just keep in mind that the code change should be as small as described here
https://trac.wxwidgets.org/wiki/HowToSu ... theProblem
OK. BTW, In China, visit trac & forum of wxWidgets is very slow, so I become lazy to visit more web pages. However the doc is good. Thanks.
PB wrote:
Fri Sep 27, 2019 5:30 am
There is usually no reason to provide project files...
Yes, platform dependent and lib path dependent.

PB
Part Of The Furniture
Part Of The Furniture
Posts: 2421
Joined: Sun Jan 03, 2010 5:45 pm

Re: How to upload code to demonstrate a bug?

Post by PB » Fri Sep 27, 2019 10:27 am

PB wrote:
Fri Sep 27, 2019 5:30 am
There is usually no reason to provide project files...
Yes, platform dependent and lib path dependent.
[/quote]

Platform dependency has nothing to with the project files. The code needs to run regardless of the IDE, not to mention that some project files are multiplatform. The platform is specified in the ticket. If the issue is with a specific compiler, it just needs to be mentioned. Last but not least, a code reproducing the issue is usually in a single file.

As for lib path dependency, TBH I really cannot imagine this kind of a bug, as paths can be freely modified in users' projects. I am not saying this cannot happen, but I believe it to be quite rare.

User avatar
doublemax
Moderator
Moderator
Posts: 14870
Joined: Fri Apr 21, 2006 8:03 pm
Location: $FCE2

Re: How to upload code to demonstrate a bug?

Post by doublemax » Fri Sep 27, 2019 10:28 am

Ronald wrote:
Fri Sep 27, 2019 10:15 am
doublemax wrote:
Fri Sep 27, 2019 5:04 am
So, is it ok to do a PR on github to show the bug? Or a standalone patch?
One of these is usually preferred.
Which one? Any one?
Yes. Any one of those.
Use the source, Luke!

Ronald
I live to help wx-kind
I live to help wx-kind
Posts: 162
Joined: Mon Mar 05, 2018 4:17 am

Re: How to upload code to demonstrate a bug?

Post by Ronald » Fri Sep 27, 2019 12:43 pm

PB wrote:
Fri Sep 27, 2019 10:27 am
As for lib path dependency, TBH I really cannot imagine this kind of a bug, as paths can be freely modified in users' projects. I am not saying this cannot happen, but I believe it to be quite rare.
I mean if providing a Visual Studio solution, the lib path for wxWidgets needs to be changed for others to run the solution.
This is not convenient.
A patch on the samples is convenient.

ONEEYEMAN
Part Of The Furniture
Part Of The Furniture
Posts: 4141
Joined: Sat Apr 16, 2005 7:22 am
Location: USA, Ukraine

Re: How to upload code to demonstrate a bug?

Post by ONEEYEMAN » Mon Sep 30, 2019 2:38 pm

Hi,
Yes, that's why people request a patch to the sample.
On top of that Vadim simply doesn't have time to study the full code, and it is easier to just apply the patch and do some debugging, then read the code, understand it and start the debugging session.

Thank you.

Post Reply