Check if Dir is Subset of a path Topic is solved

[eranon]

I've tried and it works well on my side (under Windows 7 Pro 64-bit FR edition) using this function (to be sure we talk about the same one) :

Code: Select all

bool IsSubDir(wxString strRefPath, wxString strPathToTest)
{
    wxFileName fn(strPathToTest);
    if (!fn.MakeRelativeTo(strRefPath))
        return false;
    if (fn.GetFullPath().Find("..") == 0)
        return false;
    return true;
}

Here are some test results :

snap_0000194.png (12.88 KiB) Viewed 2074 times

[evstevemd]

I've tried and it works well on my side (under Windows 7 Pro 64-bit FR edition) using this function (to be sure we talk about the same one) :

Code: Select all

bool IsSubDir(wxString strRefPath, wxString strPathToTest)
{
    wxFileName fn(strPathToTest);
    if (!fn.MakeRelativeTo(strRefPath))
        return false;
    if (fn.GetFullPath().Find("..") == 0)
        return false;
    return true;
}

Here are some test results :

snap_0000194.png

Well I will try it again may be something else was wrong than what I thought.
I use linux, Ubuntu to be specific!

[eranon]

Nothing urgent, but I think it would be nice if you could push the test (maybe related to MakeRelativeTo's underlying code against Linux), evstevemd. On my side, my dev. env. are currently only under Windows and OS X. I'm using Linux too (Ubuntu, Fedora and CentOS), but without any up and running dev environment and wxWidgets right now.

[evstevemd]

Ah! I found that my code messed up the paths and so the code works fine!