TransferToWindow and TransferFromWindow isn't called in custom validator Topic is solved

[usernameak]

TransferToWindow and TransferFromWindow isn't called in custom validator.
The validator:

Code: Select all

#pragma once

#include <wx/wx.h>

template <typename T> class WDEdCBBitValidator : public wxValidator {
    T *val;
    T bitmask;
public:
    WDEdCBBitValidator(T *val, T bitmask) : wxValidator(), val(val), bitmask(bitmask) {
        wxPrintf("Validator init\n");
    };

    virtual wxObject *Clone() const {
        wxPrintf("Validator Clone %p %p\n", m_validatorWindow, val);
        return new WDEdCBBitValidator<T>(*this);
    }

    // Called when the value in the window must be validated: this is not used
    // by this class
    virtual bool Validate(wxWindow * WXUNUSED(parent)) {
        return true;
    }

    // Called to transfer data to the window
    virtual bool TransferToWindow() {
        wxPrintf("TransferToWindow %p %p\n", m_validatorWindow, val);
        if(!m_validatorWindow || !val) return false;
        wxCheckBox *cb = (wxCheckBox *) m_validatorWindow;
        cb->SetValue((*val & bitmask) ? true : false);
        return true;
    }

    // Called to transfer data from the window
    virtual bool TransferFromWindow() {
        wxPrintf("TransferFromWindow %p %p\n", m_validatorWindow, val);
        if(!m_validatorWindow || !val) return false;
        wxCheckBox *cb = (wxCheckBox *) m_validatorWindow;
        if(cb->GetValue()) {
            *val |= bitmask;
        } else {
            *val &= ~bitmask;
        }
        return true;
    }
};

[doublemax]

At first sight i don't see anything obviously wrong. Where/how do you use it? TransferToWindow() will only be called automatically inside wxDialog(s), not inside wxFrame(s).

http://docs.wxwidgets.org/trunk/overview_validator.html

[usernameak]

I use it in a wxDialog:

Code: Select all

template <typename T> WDEdPropertiesDialog *AddBitCheckboxGroup(wxString name, T *value, std::initializer_list<WDEdBitCheckboxProperties<T> > props) {
        AddGroup(name);
        int i = 0;
        int j = sizer->GetRows();
        for(auto &prop : props) {

            sizer->Add(new wxCheckBox(panel,
                                      wxID_ANY,
                                      prop.name,
                                      wxDefaultPosition, wxDefaultSize,
                                      0L,
                                      WDEdCBBitValidator<T>(value, prop.bitmask)
                                     ), wxGBPosition(j, i++));
            if(i != i % 4) {
                j++;
                i = i % 4;
            }
        }
        return this;
    }

[Manolo]

Your validator code seems good. You don't post the code where the validator is bound or used, so hard to find an issue.

Transfer to/from window only happens automatically for dialogs, not other windows like a wxFrame.
You may call those functions as a response to some user action, e.g. the control loses focus.

[PB]

"Is not called in custom validator" implies that it works with a built-in one (wxGenericValidator)? This is quite important distinction to see whether the issue is with validation of your dialog in general or the custom validator only.

As usual, an SSCCE would be great to have...

Edit
Seems to works for me (as in both methods are getting called) with current master on MSW:

Code: Select all

#include <wx/wx.h>

template <typename T> class WDEdCBBitValidator : public wxValidator {
    T *val;
    T bitmask;
public:
    WDEdCBBitValidator(T *val, T bitmask) : wxValidator(), val(val), bitmask(bitmask) {
        wxLogMessage("Validator init\n");
    };

    virtual wxObject *Clone() const {
        wxLogMessage("Validator Clone %p %p\n", m_validatorWindow, val);
        return new WDEdCBBitValidator<T>(*this);
    }

    // Called when the value in the window must be validated: this is not used
    // by this class
    virtual bool Validate(wxWindow * WXUNUSED(parent)) {
        return true;
    }

    // Called to transfer data to the window
    virtual bool TransferToWindow() {
        wxLogMessage("TransferToWindow %p %p\n", m_validatorWindow, val);
        if(!m_validatorWindow || !val) return false;
        wxCheckBox *cb = (wxCheckBox *) m_validatorWindow;
        cb->SetValue((*val & bitmask) ? true : false);
        return true;
    }

    // Called to transfer data from the window
    virtual bool TransferFromWindow() {
        wxLogMessage("TransferFromWindow %p %p\n", m_validatorWindow, val);
        if(!m_validatorWindow || !val) return false;
        wxCheckBox *cb = (wxCheckBox *) m_validatorWindow;
        if(cb->GetValue()) {
            *val |= bitmask;
        } else {
            *val &= ~bitmask;
        }
        return true;
    }
};

class MyDialog : public wxDialog
{
public:
    MyDialog(int& value) : wxDialog(NULL, wxID_ANY, _("Test"))
    {        
        wxBoxSizer* bSizer = new wxBoxSizer(wxVERTICAL);

        wxTextCtrl* logCtrl = new wxTextCtrl(this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, wxTE_MULTILINE | wxTE_READONLY | wxTE_RICH2);        
        wxLog::SetActiveTarget(new wxLogTextCtrl(logCtrl));    

        wxCheckBox* cb = new wxCheckBox(this, wxID_ANY, "Checkbox",
                            wxDefaultPosition, wxDefaultSize, 0L, 
                            WDEdCBBitValidator<int>(&value,  0xFFFF));
        
        bSizer->Add(cb, 0);
        bSizer->Add(logCtrl, 1, wxEXPAND | wxALL, 5);                
        bSizer->Add(CreateStdDialogButtonSizer(wxOK | wxCANCEL), 0, wxEXPAND | wxALL, 5);

        wxLogMessage("Value is %d", value);

        SetSizer(bSizer);
    }	
};

class MyApp : public wxApp
{
public:
    virtual bool OnInit()
    {
        int value = 1;
        
        if ( MyDialog(value).ShowModal() == wxID_OK )
            wxMessageBox(wxString::Format("New value is %d", value));

        return false;
    }
}; wxIMPLEMENT_APP(MyApp);

I assume the issue is not something silly like using older wxWidgets and not setting wxWS_EX_VALIDATE_RECURSIVELY where necessary...

[usernameak]

"Is not called in custom validator" implies that it works with a built-in one (wxGenericValidator)? This is quite important distinction to see whether the issue is with validation of your dialog in general or the custom validator only.
I assume the issue is not something silly like using older wxWidgets and not setting wxWS_EX_VALIDATE_RECURSIVELY where necessary...

It works with wxIntegerValidator.
My version is 3.0.4

[PB]

Does the code from my previous post work on your setup, i.e., the method are called?

[usernameak]

Does the code from my previous post work on your setup, i.e., the method are called?

It does.

[usernameak]

wxWS_EX_VALIDATE_RECURSIVELY fixed the problem

[PB]

It works with wxIntegerValidator.

wxWS_EX_VALIDATE_RECURSIVELY fixed the problem

This is odd, no validator should have worked without the flag. Well, I guess all's well that ends well...