Derived class of wxTimer doesn't work Topic is solved

[cneng3]

Hello all,

I'm trying to create a simple class that derives from wxTImer. So I have code like this:

myClass.h

Code: Select all

class myClass : public wxTimer
{
	public:
		myClass();
		virtual ~myClass();
		void Notify() override;
}

myClass.cpp

Code: Select all

/// ctor and dtor

void myClass::Notify()
{
	wxLogMessage("Notified");
}

On my main thread:

Code: Select all

	m_myClass = new myClass();
	if (!m_myClass->Start(1000))
		wxLogError("Failed to start the timer");

After I ran my code. I didn't get the error message, so based on the documentation, it means the timer actually started. However, I didn't get the log message from Notify() either. So I'm really confused right now. Any help would be appreciated.

[doublemax]

That looks ok. Did you call the default wxTimer constructor?

[PB]

As doublemax said, you probably did something wrong in myClass ctor.

This works as expected

Code: Select all

#include <wx/wx.h>

class myClass : public wxTimer
{
public:
    myClass() {};    
    void Notify() override { wxLogMessage("myClass::Notify"); }
};

class MyFrame : public wxFrame
{
public:
    MyFrame() : wxFrame(NULL, wxID_ANY, "Test") 
    {
        wxTextCtrl* textCtrl = new wxTextCtrl(this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, wxTE_MULTILINE | wxTE_READONLY | wxTE_RICH2);     
        wxLog::SetActiveTarget(new wxLogTextCtrl(textCtrl));    
    
        m_myClass = new myClass();
        if (!m_myClass->Start(1000))
            wxLogError("Failed to start the timer");
    }	
private:
    myClass* m_myClass;
};

class MyApp : public wxApp
{
public:         
    bool OnInit()
    {
        (new MyFrame())->Show();               
        return true;
    }   
}; wxIMPLEMENT_APP(MyApp);

[cneng3]

That looks ok. Did you call the default wxTimer constructor?

Yes, I'm not overriding the constructor. My constructor looks something like this

Code: Select all

myClass::myClass() {}

[cneng3]

As doublemax said, you probably did something wrong in myClass ctor.

This works as expected

Code: Select all

#include <wx/wx.h>

class myClass : public wxTimer
{
public:
    myClass() {};    
    void Notify() override { wxLogMessage("myClass::Notify"); }
};

class MyFrame : public wxFrame
{
public:
    MyFrame() : wxFrame(NULL, wxID_ANY, "Test") 
    {
        wxTextCtrl* textCtrl = new wxTextCtrl(this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, wxTE_MULTILINE | wxTE_READONLY | wxTE_RICH2);     
        wxLog::SetActiveTarget(new wxLogTextCtrl(textCtrl));    
    
        m_myClass = new myClass();
        if (!m_myClass->Start(1000))
            wxLogError("Failed to start the timer");
    }	
private:
    myClass* m_myClass;
};

class MyApp : public wxApp
{
public:         
    bool OnInit()
    {
        (new MyFrame())->Show();               
        return true;
    }   
}; wxIMPLEMENT_APP(MyApp);

We have nearly identical code but it doesn't work for me

[PB]

We have nearly identical code but it doesn't work for me

Does my code works for you?

If it does, start removing parts of your code to make same as mine and once it starts working you will know where the issue is. It is probably something silly you just cannot see right now ...

If it does not there may be something wrong with your system / library build? I am on Windows BTW but that should make no difference.

[cneng3]

My code just somehow magically worked!!! I didn't change anything. Thx for all the advice guys!