Page 1 of 1

SetBellOnError inverted logic?

Posted: Mon Oct 12, 2009 9:57 am
by ikolev
Hi,

I think the parameter of wxValidator::SetBellOnError(bool) has inverted logic. The method name implies that true should cause beeps, while false should disable them. At the moment it is the opposite. Either the name of the method should be changed to SetSilent(), or the implementation should be inverted, IMO.

Regards,
Ivan

Posted: Mon Oct 12, 2009 2:49 pm
by spectrum
yes, that's true,

i added a ticket with the fix.

http://trac.wxwidgets.org/ticket/11312

Many thanks

Posted: Fri Oct 16, 2009 8:44 am
by spectrum
hello ikolev,

the iussue has someway fixed, please find the comments in the track bugreport

http://trac.wxwidgets.org/ticket/11318#comment:2

many thanks to have reported it.
regards,

Posted: Thu Nov 05, 2009 9:12 am
by ikolev
Indeed, deprecating the old function and adding a new one seems the best way to solve this.