SetBellOnError inverted logic? Topic is solved

If you are using the main C++ distribution of wxWidgets, Feel free to ask any question related to wxWidgets development here. This means questions regarding to C++ and wxWidgets, not compile problems.
Post Reply
ikolev
Earned a small fee
Earned a small fee
Posts: 10
Joined: Fri Sep 18, 2009 8:01 am

SetBellOnError inverted logic?

Post by ikolev » Mon Oct 12, 2009 9:57 am

Hi,

I think the parameter of wxValidator::SetBellOnError(bool) has inverted logic. The method name implies that true should cause beeps, while false should disable them. At the moment it is the opposite. Either the name of the method should be changed to SetSilent(), or the implementation should be inverted, IMO.

Regards,
Ivan

spectrum
Filthy Rich wx Solver
Filthy Rich wx Solver
Posts: 207
Joined: Sat Jul 21, 2007 12:17 pm

Post by spectrum » Mon Oct 12, 2009 2:49 pm

yes, that's true,

i added a ticket with the fix.

http://trac.wxwidgets.org/ticket/11312

Many thanks
spectrum

spectrum
Filthy Rich wx Solver
Filthy Rich wx Solver
Posts: 207
Joined: Sat Jul 21, 2007 12:17 pm

Post by spectrum » Fri Oct 16, 2009 8:44 am

hello ikolev,

the iussue has someway fixed, please find the comments in the track bugreport

http://trac.wxwidgets.org/ticket/11318#comment:2

many thanks to have reported it.
regards,
spectrum

ikolev
Earned a small fee
Earned a small fee
Posts: 10
Joined: Fri Sep 18, 2009 8:01 am

Post by ikolev » Thu Nov 05, 2009 9:12 am

Indeed, deprecating the old function and adding a new one seems the best way to solve this.

Post Reply