How to delete std::vector<wxString*> ? Topic is solved

[cecilio]

What is the correct method to empty a vector of wxString pointers?

I'm trying this:

Code: Select all

std::vector<wxString*>::iterator it;
for (it = m_Labels.begin(); it != m_Labels.end(); ++it)
    delete *it;
m_Labels.clear();

But I'm getting a run time error in the 'delete *it' instruction:

Debug Assert Fail. File dbgdel.cpp, Line 52.
Expression: _BLOCK_TYPE_IS_VALID(pHead->nBlockUse)

The vector is valid, as well as the contained wxString pointers.

Thank you,

[phlox81]

use the indexoperator delete vec;

Or take a look at the boost::pointercontainer library.

[cecilio]

Thank you. I don't understand anything about the behaviour of wxString*.

I tried

Code: Select all

delete m_Labels[i];

but it also fails with the same error.

I don't understand why it is failing.

Also, to use the stored strings I have to do

Code: Select all

wxString sText = (*it)->GetData();

and use &sText instead of using (*it) directly. Why this behavior? Is not (*it) a pointer to wxString?

Thank you.

[phlox81]

Why do you store Stringpointers at all?

A std::vector<wxString> would do the same.

[S.Volkenandt]

I suppose you double-delete those pointers, or the pointers stored in the vector are not allocated via new wxString.

[cecilio]

Thank you for the clues. They help me to focus on the problem. There were nothing wrong with wxString* or std::vector. It was just my fault.

I was storing pointers to temporary wxStrings, no longer existing when trying to use them. And also I cause a double delete of the strings:

Code: Select all

lmDlg dlg = new lmDlg(_("String"));
dlg->ShowModal();


lmDlg::lmDlg(const wxString& sText)
{
    m_Labels.push_back(sText);
    ...
}

lmDlg::~lmDlg()
{
    std::vector<wxString*>::iterator it;
    
    for (it = m_Labels.begin(); it != m_Labels.end(); ++it)
        delete *it;
    m_Labels.clear();
}

Thank you.

[eranif]

FYI,
You can always use wxArrayString

Eran

[cecilio]

You can always use wxArrayString

Yes, but I'm trying to avoid wxContainers when STL alternatives exist. Clearer code and more portable!

Regards,